Remove dependency on jquery-form #35240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue + SolTech feature request)
orangejenny
requested review from
a team,
esoergel,
calellowitz,
biyeun,
dannyroberts and
nospame
as code owners
dimagimon
added
dependencies
gherceg
reviewed
Oct 22, 2024
| let formData = new FormData($createForm.get(0)); | ||
| formData.set("action", "create"); | ||
| $.ajax({ | ||
| method: 'POST', | ||
| dataType: 'json', |
There was a problem hiding this comment.
I don't quite follow why we keep dataType: 'json' in this request but remove it in the other modified request in this file? Same goes for the b5 version.
There was a problem hiding this comment.
Those are spurious changes, I must have made them while troubleshooting and then not changed them back. Reading the docs now, it'd be fine to leave off dataType altogether in this code (for a default value, the docs say it makes an intelligent guess).
millerdev
approved these changes
Oct 22, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This dependency isn't really pulling its weight. I've thought about removing it before, and this morning @gherceg and I ran into an issue integrating it with webpack, so now seemed like a good time to kill it.
The API is pretty small: https://github.com/jquery-form/form
We primarily use
ajaxSubmit, and also useresetFormin a couple of places. I imagine this library was more useful when we started using it, but now we can use native js functionality that's approximately as concise.https://dimagi.atlassian.net/browse/SAAS-16090
Safety Assurance
Safety story
These are fairly minor changes on ~5 areas in HQ (although the CRUD view is used in a couple of places). I tested each of them locally.
Automated test coverage
Unlikely
QA Plan
Not requesting QA
Rollback instructions
Labels & Review